Skip to content

LG-5988: Support routing users to next MFA method when they select multiple MFA methods. #6138

Merged
mdiarra3 merged 22 commits intomainfrom
LG-5988-routing
Apr 13, 2022
Merged

LG-5988: Support routing users to next MFA method when they select multiple MFA methods. #6138
mdiarra3 merged 22 commits intomainfrom
LG-5988-routing

Conversation

@mdiarra3
Copy link
Copy Markdown
Contributor

@mdiarra3 mdiarra3 commented Apr 1, 2022

Right now this logic is still under a feature toggle introduced in #6076

Will allow users to travel across all methods via session.

When user has only one MFA or one MFA left it will direct user to their expected final destination, usually the accounts url page.

Comment thread app/controllers/concerns/mfa_setup_concern.rb Outdated
Comment thread app/controllers/two_factor_authentication/otp_verification_controller.rb Outdated
Comment thread app/forms/two_factor_options_form.rb Outdated
@mdiarra3 mdiarra3 requested a review from zachmargolis April 5, 2022 16:18
Comment thread app/controllers/concerns/mfa_setup_concern.rb
@mdiarra3 mdiarra3 requested review from aduth and mitchellhenke April 7, 2022 13:23
Comment thread app/controllers/concerns/mfa_setup_concern.rb Outdated
Copy link
Copy Markdown
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdiarra3 mdiarra3 merged commit 1e5396f into main Apr 13, 2022
@mdiarra3 mdiarra3 deleted the LG-5988-routing branch April 13, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants